-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clientconn: override authority with address's ServerName, if set #3073
Conversation
Thanks for the PR @jpbetz. LGTM, but we should also document the new behavior on |
5b34e15
to
8470538
Compare
@dfawley godoc added to I've also downstream tested this change with etcd and it works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. A couple minor things related to the new text, otherwise LGTM.
8470538
to
aae9b30
Compare
Feedback applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Fixes #3038
By default it is not set and the dialed target is used as the authority for all load balanced endpoints. This enables load balanced clients to use per-endpoint authorities when the address's ServerName is set.